Ports the RBMK from NSV (for real this time) #10364

XeonMations · 2023-12-20T21:51:27Z

About The Pull Request

Adds in the RBMK nuclear reactor from NSV. (this time hopefully without pull breaking map changes)

All things are able to be ordered from cargo.

Wiki can be found here: https://wiki.beestation13.com/view/Guide_to_the_Nuclear_Reactor

(I accidentally created the wiki on the main wiki instead of a sandbox, I'm sorry)

RBMK Hum noise sourced from here, under CC BY 4.0 and edited by me.

Why It's Good For The Game

Testing Photographs and Procedure

Screenshots&Videos

Changelog

🆑 XeonMations, Aramix, DungeonVR
add: Added the RBMK reactor, fuel rods and engine sealant, all orderable from cargo!
/:cl:

github-actions · 2023-12-23T21:12:46Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

To do: On initialization, make new ID for the RBMK and have computers auto-locate and set their own IDs to it Create and make the crate use the RBMK machine board instead of the machine + add the ability to move the RBMK when inactive

now onto the rest of the TODO list...

-Added the ability for the RBMK to alert engineers of its meltdown status over comms. (TODO: Add in a cooldown period) -Fixed some bugs revolving around the computers not linking with RBMK -Fixed bug where RBMK would not connect to a pipe layer

To do: New sprites for the RBMK, include five fuel rod variations + show where pipes input and output New SFX for the RBMK. Get the three input pipes to be made automatically correctly. Get the RBMK to be wrenchable and movable

credit to: https://freesound.org/people/guitarguy1985/sounds/54048/ license: CC0 1.0 Deed

…hanges and stuff

MarkusLarsson421 · 2024-09-14T09:02:09Z

We don't want to use this in place of the supermatter crystal which leaves it in a place where its going to be unmaintained and never used.

If it is hidden in some corner of the game, it will be unmaintained because no one will ever go to that corner and know of its existence. I would say we SHOULD allow the SM to be replaced with other engines if the situation desires it. Because then people will actually care for it and its functionality further into the feature.

With how hidden Derelict Stations are, it is no wonder how unmaintained it is. Not because PRs are being shut down, but because no one knows of its existence to make the PRs to begin with.

PowerfulBacon · 2024-09-14T22:16:29Z

A new mapping standard won't be set for stations to have their SM replaced with RBMK. We will suffer from having to maintain multiple engines, and the RBMK is not an appropriate option for a full SM replacement.

Rukofamicom · 2024-09-23T20:14:37Z

I really love the RBMK, but I ultimately agree with Bacon.

I don't want to replace the supermatter crystals with it, and I don't believe this should be merged unless it is replacing them.

Isaacnml · 2024-09-24T19:45:29Z

Please dont kill it, from initial thought it was supposed to replace the defunct antimatter reactor, which it does a pretty good job, never meant to replace the SM in any way and engineering desperately needs new content to well.. play around gameplay loop currently is really vague

It's a replacement incase the SM explodes, not a full replacement for the SM

No clue where Ambic got the full replacement for the SM idea, it was always supposed and designed to be a secondary engine, not a main one

MarkusLarsson421 · 2024-09-24T21:39:08Z

Almost a year in development and now the close keys are coming in? Jesus Christ. A year of Xeons life wasted.

XeonMations · 2024-09-25T06:53:22Z

A year of Xeons life wasted

I dont mind to be fair. I code as a hobby, something I do for fun. Not for a living.

XeonMations · 2024-09-25T06:55:41Z

from initial thought it was supposed to replace the defunct antimatter reactor

But yes, the idea from the start was as a replacement for the now gone antimatter reactor.

As of current, if the SM explodes, the station only has solars as a power source unless they want to take a rather long time setting up a black hole (good luck with no power) or a tesla (Again, good luck without power).

Or engineering could just set up a second SM in the form of a shard, but I'm unsure if they'd put that much effort in before the shuttle is called.

EvilDragonfiend · 2024-09-25T06:55:45Z

I am honestly fine with this, but I suppose we might need a kind of mapping tool to replace (or some ingame stuff to make a dedicated area quickly). Constructing a new engine for a whole round was tedious.

XeonMations · 2024-09-25T06:56:35Z

we might need a kind of mapping tool to replace (or some ingame stuff to make a dedicated area quickly). Constructing a new engine for a whole round was tedious.

Entirely fair, if wished, i am able to add one.

EvilDragonfiend · 2024-09-25T07:08:05Z

we might need a kind of mapping tool to replace (or some ingame stuff to make a dedicated area quickly). Constructing a new engine for a whole round was tedious.

Entirely fair, if wished, i am able to add one.

not right now. we are in a mapping disaster rn.

PowerfulBacon

Eh whatever, this can replace the antimatter generator.

EvilDragonfiend

Replace arbitrary names like R or N. It tells no context.

EvilDragonfiend

Code looks alright as long as change requests are applied.

code/modules/power/rbmk/rbmk_monitoring.dm

code/modules/power/rbmk/rbmk_procs.dm

code/modules/power/rbmk/rbmk_monitoring.dm

code/modules/power/rbmk/rbmk_parts.dm

code/modules/power/rbmk/fuel_rods.dm

EvilDragonfiend

Would be a final.

code/modules/power/rbmk/rbmk_monitoring.dm

code/modules/power/rbmk/rbmk_procs.dm

Co-authored-by: EvilDragonfiend <[email protected]>

EvilDragonfiend

okay, we'll see how this goes.

BarteG44 · 2024-11-24T20:23:21Z

YES YES YES YES

done?

b3ba36c

github-actions bot added Sprites Sound TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Dec 20, 2023

XeonMations mentioned this pull request Dec 20, 2023

Ports the RBMK from NSV #9993

Closed

solid-octo-guacamole bot added the Feature label Dec 20, 2023

XeonMations marked this pull request as draft December 20, 2023 21:52

Merge branch 'BeeStation:master' into RBMK2ElectricBoogaloo

bcaa7c1

github-actions bot added the Merge Conflict label Dec 23, 2023

XeonMations added 12 commits December 24, 2023 03:52

added crate

4c3c7e6

To do: On initialization, make new ID for the RBMK and have computers auto-locate and set their own IDs to it Create and make the crate use the RBMK machine board instead of the machine + add the ability to move the RBMK when inactive

fixed tools.dmi

cb765be

Circuit board done!

5b2f2b7

now onto the rest of the TODO list...

2

3a47020

-Added the ability for the RBMK to alert engineers of its meltdown status over comms. (TODO: Add in a cooldown period) -Fixed some bugs revolving around the computers not linking with RBMK -Fixed bug where RBMK would not connect to a pipe layer

work

67a1b0c

To do: New sprites for the RBMK, include five fuel rod variations + show where pipes input and output New SFX for the RBMK. Get the three input pipes to be made automatically correctly. Get the RBMK to be wrenchable and movable

day 2

10bace7

progress?

91ec5b6

still not working...

c0796c0

For dakae!

527d332

to do: refactor

d3c8c55

refactor 1

b78a755

soon:tm:

dc5be2d

github-actions bot added the Administration label Apr 3, 2024

day 2 of new code

bde0419

github-actions bot removed the Administration label Apr 9, 2024

XeonMations added 5 commits April 12, 2024 09:25

DAY @*()#&@!#(*

84a0339

remove unnecessary sounds, fix runtime issue

ba38659

New alarm.ogg sfx

165d657

credit to: https://freesound.org/people/guitarguy1985/sounds/54048/ license: CC0 1.0 Deed

turns out unnecessary sounds were infact necessary, as well as icon c…

120de46

…hanges and stuff

Final!

b42148f

Rukofamicom added the 🔑 Close Key (2/3) label Sep 23, 2024

This comment was marked as off-topic.

Sign in to view

PowerfulBacon approved these changes Nov 16, 2024

View reviewed changes

EvilDragonfiend requested changes Nov 21, 2024

View reviewed changes

no more arbitrary names

86262c6

EvilDragonfiend requested changes Nov 22, 2024

View reviewed changes

XeonMations added 2 commits November 22, 2024 21:02

womp womp

e8817a9

Update rbmk_procs.dm

2155934

EvilDragonfiend requested changes Nov 23, 2024

View reviewed changes

code/modules/power/rbmk/rbmk_monitoring.dm Outdated Show resolved Hide resolved

code/modules/power/rbmk/rbmk_monitoring.dm Outdated Show resolved Hide resolved

code/modules/power/rbmk/rbmk_procs.dm Outdated Show resolved Hide resolved

XeonMations and others added 4 commits November 23, 2024 17:11

Update code/modules/power/rbmk/rbmk_monitoring.dm

9f631fd

Co-authored-by: EvilDragonfiend <[email protected]>

Update code/modules/power/rbmk/rbmk_monitoring.dm

cb6a3a9

Co-authored-by: EvilDragonfiend <[email protected]>

Update code/modules/power/rbmk/rbmk_procs.dm

4b44f6a

Co-authored-by: EvilDragonfiend <[email protected]>

Update rbmk_monitoring.dm

09f240a

EvilDragonfiend approved these changes Nov 23, 2024

View reviewed changes

EvilDragonfiend added this pull request to the merge queue Nov 23, 2024

Merged via the queue into BeeStation:master with commit 0926e7d Nov 23, 2024
21 checks passed

ss13-beebot added a commit that referenced this pull request Nov 23, 2024

Automatic changelog generation for PR #10364 [ci skip]

f6ed0bc

XeonMations deleted the RBMK2ElectricBoogaloo branch November 23, 2024 21:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports the RBMK from NSV (for real this time) #10364

Ports the RBMK from NSV (for real this time) #10364

XeonMations commented Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 23, 2023

MarkusLarsson421 commented Sep 14, 2024

PowerfulBacon commented Sep 14, 2024

Rukofamicom commented Sep 23, 2024

Isaacnml commented Sep 24, 2024 •

edited

Loading

MarkusLarsson421 commented Sep 24, 2024

XeonMations commented Sep 25, 2024

XeonMations commented Sep 25, 2024

EvilDragonfiend commented Sep 25, 2024

XeonMations commented Sep 25, 2024

EvilDragonfiend commented Sep 25, 2024

This comment was marked as off-topic.

PowerfulBacon left a comment

EvilDragonfiend left a comment

EvilDragonfiend left a comment

EvilDragonfiend left a comment

EvilDragonfiend left a comment

BarteG44 commented Nov 24, 2024

Ports the RBMK from NSV (for real this time) #10364

Ports the RBMK from NSV (for real this time) #10364

Conversation

XeonMations commented Dec 20, 2023 • edited Loading

About The Pull Request

Why It's Good For The Game

Testing Photographs and Procedure

Changelog

github-actions bot commented Dec 23, 2023

MarkusLarsson421 commented Sep 14, 2024

PowerfulBacon commented Sep 14, 2024

Rukofamicom commented Sep 23, 2024

Isaacnml commented Sep 24, 2024 • edited Loading

MarkusLarsson421 commented Sep 24, 2024

XeonMations commented Sep 25, 2024

XeonMations commented Sep 25, 2024

EvilDragonfiend commented Sep 25, 2024

XeonMations commented Sep 25, 2024

EvilDragonfiend commented Sep 25, 2024

This comment was marked as off-topic.

PowerfulBacon left a comment

Choose a reason for hiding this comment

EvilDragonfiend left a comment

Choose a reason for hiding this comment

EvilDragonfiend left a comment

Choose a reason for hiding this comment

EvilDragonfiend left a comment

Choose a reason for hiding this comment

EvilDragonfiend left a comment

Choose a reason for hiding this comment

BarteG44 commented Nov 24, 2024

XeonMations commented Dec 20, 2023 •

edited

Loading

Isaacnml commented Sep 24, 2024 •

edited

Loading